chore(repo): Fix yarn clean(:all) scripts#7478
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 16, 2023
mydea
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-level
yarn clean(:all)commands didn't work for me for quite a while now. The normal clean command was flaky while the other one always error'd. My suspicion is that cleaning the NX cache and running commands on the individual packages seems to collide. Likewise, removingnode_moduleswhile using an npm package (rimraf) to clean things. Running the individual clean commands in series vs. in parallel seems to fix this for me.