test(tracing): Check if beforeNavigate does not change source#7473
Merged
AbhiPrasad merged 2 commits intodevelopfrom Mar 16, 2023
Merged
test(tracing): Check if beforeNavigate does not change source#7473AbhiPrasad merged 2 commits intodevelopfrom
beforeNavigate does not change source#7473AbhiPrasad merged 2 commits intodevelopfrom
Conversation
Lms24
approved these changes
Mar 16, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
customis the default and the test above already checks for this, I changed the semantics of the test to make sure we were settingurlproperly.Did this while validating a customer issue hence why changes here.