feat(tracing): Bring back finishReason for interaction transactions#7449
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 14, 2023
Merged
feat(tracing): Bring back finishReason for interaction transactions#7449AbhiPrasad merged 1 commit intodevelopfrom
finishReason for interaction transactions#7449AbhiPrasad merged 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several interaction transactions in production that have no spans at all, and we want to find out why this is the case.
This PR reintroduces
finishReasonfrom e0f9ca0 but only sets it as a tag for interaction transactions.This is only temporary, this tag will allow us to diagnose the reason for why interaction transactions appear to be ending early, or without any data. We can remove it from the SDK once we've finished investigating.
Here's an example of one of these strange transactions:
