feat(bundles): Ensure CDN bundles always have a Replay export#7414
Merged
feat(bundles): Ensure CDN bundles always have a Replay export#7414
Replay export#7414Conversation
Lms24
approved these changes
Mar 13, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Generally this LGTM. I think the build error is related to the tracing bundle not being able to resolve the relative path to the shim file.
I guess the one downside here is that this increases the bundle size of the non-replay bundles somewhat unnecessarily. But I understand that this is the lesser of two evils 😅
a16ebe8 to
2b85800
Compare
Contributor
size-limit report 📦
|
2b85800 to
bd507e8
Compare
bd507e8 to
2968e20
Compare
AbhiPrasad
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure we export
Replayin CDN bundles that do not include the actual Replay code.This will export a minimal shim that covers the public API we have, and logs a message.
If we think that's good, we can look to use a similar approach for BrowserTracing (TBD - this is a bit different, but let's see).
Nicely, we can actually cover this quite well with our playwright tests 🎉
Closes #7393