Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
I'm actually not sure if there isn't some sort of problem with our flushing implementation rather than with test flakiness. We set |
Member
Author
|
Hmm we're even getting outliers with delays >2s: https://github.com/getsentry/sentry-javascript/actions/runs/4254985922/jobs/7402098735#step:11:264 It might just be that the runners are so slow that this just keeps on happening despite the maxdelay we set 🤔 |
90d5f6b to
c567ade
Compare
mydea
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flakiness of our replay event flushing test by slightly changing the test requirements/expectations:
Note: I tested that flakes were gone by running this test 75x per CI job for multiple times and didn't see this test failing anymore.
closes #7266