test(replay): Ensure that unicode characters are handled correctly#7252
Merged
test(replay): Ensure that unicode characters are handled correctly#7252
Conversation
Member
|
This is nice, might be worthwhile to also include this in the E2E test: #7249 - I'll leave a note there! |
mydea
approved these changes
Feb 22, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #7082 we figured it'd be worthwhile to check that we handle unicode characters correctly. Especially when compressing payload we should check that nothing goes wrong.
Note: This test obviously only checks that the payloads leave the SDK correctly. It cannot say anything about the replayer rendering them correctly in the Sentry UI.
ref #7044