ci: Add timeout to integration tests job#7243
Merged
Conversation
AbhiPrasad
approved these changes
Feb 21, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
With this we can bash even more flaky tests!
Lms24
reviewed
Feb 22, 2023
.github/workflows/build.yml
Outdated
| needs: [job_get_metadata, job_build] | ||
| if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request' | ||
| runs-on: ubuntu-20.04 | ||
| timeout-minutes: 10 |
Member
There was a problem hiding this comment.
I'm probably missing something but aren't we already pretty close to 10 minutes? Just wondering if this is maybe a little too tight, wdyt?
Member
Author
There was a problem hiding this comment.
yeah, you're right, it varies a lot (sometimes 5min, sometimes 9min, ...) - I'll bump it to 15min!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed that the playwright tests go on forever, so adding a 10min timeout there should help.
Also reducing this from 30m to 10m for some other jobs, which should be sufficient IMHO.