test(replay): Add test for fetch and XHR performance spans#7224
Merged
test(replay): Add test for fetch and XHR performance spans#7224
Conversation
AbhiPrasad
approved these changes
Feb 17, 2023
billyvg
approved these changes
Feb 17, 2023
Member
|
This is good, but IMHO we should try to find a way to actually test the values of the payloads as well. This is obv. tricky due to timing etc., but in order to gain greater safety about e.g. unit mismatches and stuff like this, it would be awesome to have something like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two Playwright tests to test fetch/xhr requests being recorded as performance spans
ref #7044