build(replay): Improve replay-worker build#7173
Merged
Conversation
AbhiPrasad
approved these changes
Feb 14, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Nice, I like this approach!
Contributor
size-limit report 📦
|
ramchaik
pushed a commit
to ramchaik/sentry-javascript
that referenced
this pull request
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the build for the replay worker:
build:transpileandbuild:typesare actually separate things, to avoid conflictsvendorstuff as-is, but relying on rollupBasically, we now keep the worker in
_worker.ts, whileworker.tsis just a placeholder that is replaced at built time with the string-wrapped & resolved version of_worker.ts. This way, the imports etc. work as expected, and we can actually generate the types normally.I also aligned the build structure with other packages, the output is now:
While
index.jsis:and
worker.jsis: