chore(replay): Update README.md sample rate default values#7162
Merged
Lms24 merged 2 commits intogetsentry:masterfrom Feb 13, 2023
Merged
chore(replay): Update README.md sample rate default values#7162Lms24 merged 2 commits intogetsentry:masterfrom
README.md sample rate default values#7162Lms24 merged 2 commits intogetsentry:masterfrom
Conversation
getsentry#6878 altered on version 7.33.0 the default to 0 but the docs still point as if the default was 1.0
Lms24
reviewed
Feb 13, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Good catch, thanks! Let's just make sure they're both updated.
README.md sample rate default values
Member
|
Ooops I missed the target branch 🙈 synced master->develop so everything is up to date. @lucas-zimerman just FYI, we recently changed our branching model to gitflow. Next time, please open PRs against (although, considering that we GA replay today, it's probably good that this is on master anyway, so let's just call it a happy accident 😅 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6878 altered on version 7.33.0 the default to 0 but the docs still point as if the default was 1.0
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).#skip-changelog