Conversation
mydea
commented
Feb 10, 2023
| NX_CACHE_RESTORE_KEYS: | | ||
| nx-Linux-${{ github.ref }}-${{ github.event.inputs.commit || github.sha }} | ||
| nx-Linux-${{ github.ref }} | ||
| nx-Linux-refs/heads/develop |
Member
Author
There was a problem hiding this comment.
Note: I figured this isn't actually necessary, because the way cache works is that it only ever fetches from the current branch OR the default branch (=develop), so it can't even get the cache from a different branch. so should be all good without this.
Contributor
Damn haha |
lforst
approved these changes
Feb 10, 2023
Contributor
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| c3806eb | +79.85 ms | -0.00 ms | +12.10 pp | +1.05 MB | +2.16 MB | +2.54 kB | +41 B | +1 | +93.58 ms |
| b49d9f7 | +52.79 ms | -0.00 ms | +15.46 pp | +1.07 MB | +2.21 MB | +2.59 kB | +41 B | +1 | +70.48 ms |
| 7e57cb7 | +47.89 ms | +0.00 ms | +10.59 pp | +1.09 MB | +2.21 MB | +2.59 kB | +41 B | +1 | +72.93 ms |
| 538c3a6 | +63.63 ms | +0.00 ms | +14.14 pp | +1.07 MB | +2.16 MB | +2.6 kB | +41 B | +1 | +112.08 ms |
| fc7b716 | +52.44 ms | +0.00 ms | +14.74 pp | +1.09 MB | +2.21 MB | +2.68 kB | +41 B | +1 | +89.64 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 10 Feb 2023 14:21:32 GMT
Last updated: Fri, 10 Feb 2023 14:21:32 GMT
mydea
commented
Feb 10, 2023
| text: ${{ github.head_ref }} | ||
| # match: preprare-release/xx.xx.xx | ||
| regex: '^preprare-release\/(\d+\.\d+\.\d+)$' | ||
| regex: '^prepare-release\/(\d+\.\d+\.\d+)$' |
Member
Author
There was a problem hiding this comment.
Oops, there was a typo here, so it didn't trigger this before.
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 14, 2023
ramchaik
pushed a commit
to ramchaik/sentry-javascript
that referenced
this pull request
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some small adjustments to our cache setup:
actions/cache/restorein most places, as actually after the initial runs we only want to read from the cache, never update it.node_modules. I guess it can lead to cache conflicts otherwise, as we cache node_modules for the dependencies, and node_modules/.cache/nx for Nx. Now, the Nx cache is in.nxcachein the root dir.