fix(node): Add lru cache to http integration span map#7064
Merged
AbhiPrasad merged 2 commits intodevelopfrom Feb 7, 2023
Merged
fix(node): Add lru cache to http integration span map#7064AbhiPrasad merged 2 commits intodevelopfrom
AbhiPrasad merged 2 commits intodevelopfrom
Conversation
lforst
approved these changes
Feb 6, 2023
Lms24
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to prevent unbounded memory pressure let's make the
createSpanUrlMapin theHttpintegration an lru cache, and fix it to 100 URLs. 100 should be enough to justify the existence of this, but not enough to use a lot of memory.fixes #7060