-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Disable createSpanUrlMap #7060
Copy link
Copy link
Closed
Labels
Meta: Help WantedPackage: nodeIssues related to the Sentry Node SDKIssues related to the Sentry Node SDK
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which package are you using?
@sentry/node
SDK Version
7.31.1
Framework Version
n/a
Link to Sentry event
n/a
SDK Setup
Sentry.init({
...
integrations: [
new Sentry.Integrations.Http({
tracing: {
shouldCreateSpanForRequest: url => !url.includes('newrelic.com'),
},
}),
],
});Steps to Reproduce
See Actual Result
Expected Result
See Actual Result
Actual Result
In https://github.com/getsentry/sentry-javascript/blob/develop/packages/node/src/integrations/http.ts#L141-L156, shouldCreateSpanForRequest requests are cached in a map. This is intended behaviour with good thought, but a way to disable this would be good.
In our application, we are making a lot of network requests to a variety of different URLs that contain a many distinct combinations of many IDs. Over time, this has led to roughly 250 MB of strings only, stored in that very object.
As caching these lookups is not worth it in our case, an option would be good to disable this behaviour.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Meta: Help WantedPackage: nodeIssues related to the Sentry Node SDKIssues related to the Sentry Node SDK
Fields
Give feedbackNo fields configured for issues without a type.