ref(replay): Send SDK version in Replay events#6814
Merged
Conversation
Contributor
size-limit report 📦
|
5f4da9e to
a8a1cea
Compare
mydea
reviewed
Jan 17, 2023
| version: __SENTRY_REPLAY_VERSION__, | ||
| name, | ||
| name: name || 'sentry.javascript.unknown', | ||
| version: version || '0.0.0', |
Member
There was a problem hiding this comment.
Just to be sure, version will already have been replaced somewhere else here, right?
Member
Author
There was a problem hiding this comment.
Yes, version is set automatically during SDK initialization:
sentry-javascript/packages/react/src/sdk.ts
Lines 9 to 16 in 6557844
The reason for providing the fallback here is that users can potentially delete it or use a custom or an old client that doesn't yet have getSdkMetadata.
mydea
approved these changes
Jan 18, 2023
a8a1cea to
18146a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now export Replay via the Browser SDK we can now send the SDK version instead of the Replay package.json version, allowing us to get rid of the custom rollup config to inject said version.
closes #6366