ref(nextjs): Use loader for rather than webpack plugin for injecting release#6404
Merged
lobsterkatie merged 3 commits intomasterfrom Dec 5, 2022
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Dec 5, 2022
3 tasks
This was referenced Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replicates the release-injection functionality provided by the webpack plugin using the prefix loader instead, in hopes of fixing #5734, wherein the release value is somehow getting stuck on an old value. (My theory is that the file injected by the webpack plugin to inject the release is getting cached. This therefore switches to injecting the code setting the release using a loader, so that it's in the same file as, and just before, the
Sentry.init()call.)Fixes #5734