ref(replay): Export WINDOW within Replay instead of importing it from Browser#6386
Merged
ref(replay): Export WINDOW within Replay instead of importing it from Browser#6386
WINDOW within Replay instead of importing it from Browser#6386Conversation
mydea
reviewed
Dec 2, 2022
Contributor
size-limit report 📦
|
ddf3ca4 to
4893d11
Compare
mydea
approved these changes
Dec 2, 2022
This was referenced Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of generating CDN bundles, this PR copies the
WINDOWconstant declaration from@sentry/browserto the Replay package and updates the imports to use the package-internal version ofWINDOW. This has two advantages:@sentry/browseranymore. This previously caused the generated bundles to not work correctly and it unnecessarily increased bundle size@sentry/browserwe avoid a circular dependency one we export the Replay integration from the Browser SDK.ref #6362