Conversation
6 tasks
Lms24
approved these changes
Nov 30, 2022
Comment on lines
182
to
193
| if (usingDeprecatedCaptureOnlyOnError) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| '[@sentry/replay]: The `captureOnlyOnError` option is deprecated! Please configure `errorSampleRate` instead.', | ||
| ); | ||
| } | ||
|
|
||
| if (usingDeprecatedReplaysSamplingRate) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| '[@sentry/replay]: The `replaysSamplingRate` option is deprecated! Please configure `sessionSampleRate` instead.', | ||
| ); |
Member
There was a problem hiding this comment.
I think the change is good for now but WDYT, should we think about removing these deprecated options? We're still in alpha and soon bumping to 7.x so it might be wort a thought.
Member
Author
There was a problem hiding this comment.
Yes, I would remove them in a separate PR. I think it makes sense to put this into the 0.x --> 7.x changelog, as people will be most likely to actually read that!
Member
There was a problem hiding this comment.
Yes, separate PR sounds good to me. Let's just make sure to keep the Replay team informed about it.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enabled
no-consoleeslint rule.I left two cases of actual
console.warnin, where it is basically a deprecation for old settings (which we can probably eventually delete).