fix(replay): Temporarily build Replay after other packages#6307
Merged
fix(replay): Temporarily build Replay after other packages#6307
Conversation
move replay build to `build:extras` to ensure that types of its deps build first
mydea
reviewed
Nov 25, 2022
packages/replay/package.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| "scripts": { | |||
| "bootstrap": "yarn && cd demo && yarn #TODO: change after migration", | |||
| "build": "yarn build:rollup", | |||
Member
There was a problem hiding this comment.
hmm, will this work? As build calls build:rollup? 😅 I guess either change build to call build:extra, or remove it? (not sure)
Member
Author
There was a problem hiding this comment.
good point. I think for CI we'd be fine because build isn't called from the CI (the top-level yarn build executes build:rollup in every package). But I changed it anyway for consistency
mydea
approved these changes
Nov 25, 2022
Member
mydea
left a comment
There was a problem hiding this comment.
Seems good for now! We can/should revisit later then 👍
Member
Author
|
Definitely, this is only a temporary workaround. Should be resolved as soon as we use our transpiling process where we don't care about type declarations. |
Contributor
size-limit report 📦
|
Lms24
added a commit
that referenced
this pull request
Nov 30, 2022
Update Replay's build config to use our monorepo's rollup config for building and transpiling the Replay integration. With this patch, we're introducing a breaking change because the tarball structure is going to change. However, this only breaks users who imported from package-internal paths directly and not from the top-level package. More specifically, these are the changes: * Move and rename`./config/rollup.config.core.ts` to `./rollup.npm.config.js` which now uses our `makeNPMConfigVariants` and `makeBaseNPMConfig` rollup config helper functions to create ESM and CJS transpiled JS, just like in all our other packages. For now we have to change this to JavaScript but we can ofc revisit having TS-based rollup configs in the future. * Instead of bundling everything into the `index.js` files, this config now just transpiles the individual modules. This is how we do it in all our other packages. We might have to revisit this strategy for vendoring rrweb and bundling but we can build on top of this PR to do so. * Move and rename `./config/rollup.worker.config.ts` to `./rollup.worker.config.js` (no changes) * Update eslint configs * Fix a few type errors I came across while performing these build changes * Update `package.json` scripts so that they are in line with the scripts of our other packages. This should simplify the scripts a little. * Revert #6307 as we now transpile and check/build types separately, like we do with the rest of our packages. * Revert #6341 as the`__SENTRY_DEBUG__` flag is now set in our rollup helper functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a build error in Replay process by building it after all other packages (including their type declarations) were built. We have to do this temporarily because
@rollup/plugin-typescriptexpects type declarations of the@sentry/*dependencies of the replay package. Because we're building types in parallel to transpiling JS, type declarations were not yet (reliably) built before replay'sbuild:rollupcommands was executed.To unblock us, we for now build the package via
build:extrasso that it only runs after all other packages were fully built.We should revert this change as soon as we use our transpilation process (sucrase) where we don't care about type declarations.
This might also fix the size-limit action on the master branch.