chore(test): Add tests for skipping of integrations for otel#6143
Merged
mydea merged 3 commits intofn/disable-node-auto-instrumentationfrom Nov 8, 2022
Merged
Conversation
71492a8 to
312b948
Compare
a23430f to
46a4917
Compare
Contributor
size-limit report 📦
|
AbhiPrasad
reviewed
Nov 8, 2022
Lms24
approved these changes
Nov 8, 2022
AbhiPrasad
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some tests to an in-progress branch for skipping auto-instrumentation when enabling the otel instrumenter.
As it is kind of hard to test if integrations run with the current setup (because integrations, by design, only run once on the global hub), I added an extra
_wasSkippedproperty to the instrumentations to allow us to test this.Not 100% sure if this is ideal, but couldn't come up with something better - happy for other ideas as well! It at least works and tests what we actually want to test, I'd say.
(Note the base for this PR is not master but a different, WIP branch)