ref(core): Pre-beforeSendTransaction cleanup#6135
Merged
lobsterkatie merged 10 commits intomasterfrom Nov 4, 2022
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Nov 4, 2022
Member
Lms24
left a comment
There was a problem hiding this comment.
LGTM. Thanks for pulling this out and for the individual commits - makes reviewing easier.
Comment on lines
-1100
to
-1111
| contexts: { | ||
| trace: { | ||
| op: 'pageload', | ||
| span_id: 'a3df84a60c2e4e76', | ||
| trace_id: '86f39e84263a4de99c326acab3bfe3bd', | ||
| }, | ||
| }, | ||
| environment: 'production', | ||
| event_id: '972f45b826a248bba98e990878a177e1', | ||
| spans: [], | ||
| start_timestamp: 1591603196.614865, | ||
| timestamp: 1591603196.728485, |
Member
There was a problem hiding this comment.
So this is just stuff we didn't need for the test?
Member
Author
There was a problem hiding this comment.
Yup. It has nothing to do with the name-change data we're testing, so in the end it's just noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of a bunch of small and mostly dumb fixes pulled from #6121 (along with a few others I happened upon in the course of working on it), in order to make that PR easier to review. Some of the changes are cosmetic (formatting and wordsmithing test names, adding comments, etc.), some are refactors for clarity (mostly renaming of variables), one or two are test changes which will be necessary for the tests introduced in #6121 (in order to keep the
beforeSendandbeforeSendTransactiontests as parallel as possible, in case we ever want to parameterize them), one is pulling unneeded extra data out of a test to make it simpler, and two are actual fixes, namely:In the outcomes test, we were recording a session being dropped by
beforeSend, but sessions don't go throughbeforeSend, so it's now an error event.In many places in the base client tests, we were using
.toBe()rather thantoEqual()for values (like numbers and strings) which as far as I know aren't guaranteed to be singletons (the waytrueandfalseare, for example). This switches to usingtoEqual()in those cases.Note: Each commit is a single one of the above changes, in case it's easier to review that way.