fix(gatsby): Include app-* entrypoints as they may include user source code#5685
fix(gatsby): Include app-* entrypoints as they may include user source code#5685AbhiPrasad merged 1 commit intogetsentry:masterfrom
Conversation
|
Hi @Auspicus, thanks for opening up this PR. Before we approve and merge this, could you explain a little more what is in this |
|
@Lms24 The current codebase actually ignores the app-* entrypoint. I think previous versions of Gatsby (before v4) would only bundle core code in the app-* entrypoint but somewhere in v4 this changed. This has at least been what I have found from the few sites I've looked at. The change here removes app-* from the ignore list so its sourcemaps are included and uploaded to Sentry. I am following up with the Gatsby team to confirm this and will respond here once I know more. |
|
Right, I mixed this up. Thanks, for following up. Just ping any of us when you have an answer, then we'll give this PR another review. Cheers! |
|
@Lms24 Here's a start I guess. I'm still trying to dig through the Webpack config to point to the exact places where this is happening but the docs explain that if a module is included in more than one chunk it may end up in EDIT: Here's the relevant Webpack config although it's hard to pinpoint a specific line that would dictate that EDIT2: There's also this blog post from Ben Robertson about the contents of the different chunks: https://ben.robertson.is/notes/gatsby-and-bundle-chunking EDIT3: And Gatsby docs for more detailed explanation: https://www.gatsbyjs.com/docs/how-code-splitting-works/ |
AbhiPrasad
left a comment
There was a problem hiding this comment.
Hey! Thanks for the PR. Let's merge this in, we can always revert if folks come back and give feedback.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).TODO: