feat(nextjs): Make tracing package treeshakable#5166
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
reviewed
May 25, 2022
packages/tracing/test/index.test.ts
Outdated
| it('is exported correctly', () => { | ||
| Object.keys(Integrations).forEach(key => { | ||
| // Skip BrowserTracing because it doesn't have a static id field. | ||
| if (key !== 'BrowserTracing') { |
Member
There was a problem hiding this comment.
This should be the other way round, right?
Suggested change
| if (key !== 'BrowserTracing') { | |
| if (key === 'BrowserTracing') { |
Lms24
approved these changes
May 25, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
mydea
added a commit
that referenced
this pull request
Apr 4, 2023
This was removed in #5166 due to tree shaking concerns, however we have had a static ID for replay and it has been working fine so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
@sentry/tracingtreeshakable from@sentry/nextjs, by text-replacing__SENTRY_TRACING__withfalsein any bundler or pre-processor.Ref: https://getsentry.atlassian.net/browse/WEB-713