fix(ember): Use correct import from @sentry/browser#3077
Merged
kamilogorek merged 1 commit intogetsentry:masterfrom Nov 26, 2020
Merged
fix(ember): Use correct import from @sentry/browser#3077kamilogorek merged 1 commit intogetsentry:masterfrom
@sentry/browser#3077kamilogorek merged 1 commit intogetsentry:masterfrom
Conversation
Contributor
|
Good catch, thanks! |
|
@kamilogorek I ran into this same issue in my project today with both the browser and node packages. Is it possible to make it seems to fix the issue. Not sure if there is any downside to doing this. It's potentially a big problem to run into since an error calling |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code
import Sentry from '@sentry/browser';seems to work but is not actually correct, as@sentry/browserhas no default export. I noticed this when trying out using embroider to build our app, where it warned me about this.