fix(integrations): Add tests for CustomEvent handling fix#2431
Merged
kamilogorek merged 3 commits intomasterfrom Feb 19, 2020
Merged
fix(integrations): Add tests for CustomEvent handling fix#2431kamilogorek merged 3 commits intomasterfrom
CustomEvent handling fix#2431kamilogorek merged 3 commits intomasterfrom
Conversation
Contributor
CustomEvent handling fixCustomEvent handling fix
CustomEvent handling fixCustomEvent handling fix
kamilogorek
approved these changes
Feb 17, 2020
kamilogorek
reviewed
Feb 17, 2020
| summary.events[0].exception.values[0].mechanism.type, | ||
| "onunhandledrejection" | ||
| ); | ||
| // even though it's a regular Event (rather than a PRE) it should sill only |
Contributor
There was a problem hiding this comment.
Suggested change
| // even though it's a regular Event (rather than a PRE) it should sill only | |
| // even though it's a regular Event (rather than a PRE) it should still only |
kamilogorek
reviewed
Feb 17, 2020
packages/browser/test/integration/suites/onunhandledrejection.js
Outdated
Show resolved
Hide resolved
kamilogorek
approved these changes
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests to #2429.