Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
7d220e3 to
672ad18
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new @sentry/elysia package to the monorepo to provide first-party Sentry support for the Elysia framework (Bun-first), including SDK initialization, Elysia app wiring, and E2E coverage.
Changes:
- Introduces the new
@sentry/elysiapackage (build config, exports, types, README/license, unit tests). - Implements
init()(built on@sentry/bun) andwithElysia()(OTel plugin + request/error hooks + span cleanup/enrichment). - Adds a Bun + Elysia Playwright E2E test application and wires it into CI/publishing metadata.
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Adds Elysia + OTel plugin dependency graph and related transitive updates. |
packages/elysia/tsconfig.types.json |
Type build config for generating .d.ts output. |
packages/elysia/tsconfig.test.json |
Test TS config (Bun types) for the new package. |
packages/elysia/tsconfig.json |
Package TS config (Bun types) for source compilation. |
packages/elysia/test/withElysia.test.ts |
Unit tests for withElysia() hook registration, header propagation, and error capturing behavior. |
packages/elysia/test/sdk.test.ts |
Unit tests for init() and getDefaultIntegrations() behavior. |
packages/elysia/src/withElysia.ts |
Core Elysia wiring: OTel plugin registration, request metadata, response header propagation, error capture, span filtering/enrichment. |
packages/elysia/src/types.ts |
Defines ElysiaOptions as BunOptions. |
packages/elysia/src/sdk.ts |
Implements init() and Bun default integration filtering. |
packages/elysia/src/index.ts |
Public API surface: re-exports from @sentry/bun plus Elysia-specific exports. |
packages/elysia/rollup.npm.config.mjs |
Rollup config for publishing build artifacts. |
packages/elysia/package.json |
New package manifest (deps/peers/scripts/exports). |
packages/elysia/README.md |
Usage documentation and links for the new SDK. |
packages/elysia/LICENSE |
Package license file. |
packages/elysia/.eslintrc.js |
Package-local ESLint configuration. |
package.json |
Adds packages/elysia workspace + new resolutions for OTel packages. |
dev-packages/e2e-tests/verdaccio-config/config.yaml |
Allows publishing @sentry/elysia to local registry for E2E tests. |
dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts |
Updates export consistency checks (ignore list additions). |
dev-packages/e2e-tests/test-applications/bun-elysia/tsconfig.json |
TS config for the new Bun+Elysia E2E app. |
dev-packages/e2e-tests/test-applications/bun-elysia/tests/transactions.test.ts |
E2E validation for transactions, route parameterization, lifecycle spans, and manual spans. |
dev-packages/e2e-tests/test-applications/bun-elysia/tests/propagation.test.ts |
E2E validation for inbound propagation headers + documented fixmes for outbound propagation gaps. |
dev-packages/e2e-tests/test-applications/bun-elysia/tests/isolation.test.ts |
Documented fixme for per-request isolation behavior. |
dev-packages/e2e-tests/test-applications/bun-elysia/tests/errors.test.ts |
E2E validation for error capture rules and request metadata inclusion. |
dev-packages/e2e-tests/test-applications/bun-elysia/start-event-proxy.mjs |
Starts local event proxy for E2E capture. |
dev-packages/e2e-tests/test-applications/bun-elysia/src/app.ts |
E2E fixture Elysia app exercising routes, errors, propagation, and concurrency. |
dev-packages/e2e-tests/test-applications/bun-elysia/playwright.config.mjs |
Playwright runner config for the new E2E app. |
dev-packages/e2e-tests/test-applications/bun-elysia/package.json |
E2E app manifest (depends on @sentry/elysia). |
dev-packages/e2e-tests/test-applications/bun-elysia/.npmrc |
Points test app to local Verdaccio. |
dev-packages/e2e-tests/test-applications/bun-elysia/.gitignore |
Ignores build output for the E2E app. |
README.md |
Adds @sentry/elysia to the list of SDKs. |
.size-limit.js |
Adjusts bundle size limits (likely due to dependency graph changes). |
.github/workflows/build.yml |
Ensures Bun is set up for the new bun-elysia E2E matrix entry. |
.github/ISSUE_TEMPLATE/bug.yml |
Adds @sentry/elysia to bug report SDK dropdown. |
.craft.yml |
Adds publishing target configuration for @sentry/elysia. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts
Show resolved
Hide resolved
Comment on lines
+22
to
+59
| function getRuntime(): { name: string; version: string } { | ||
| if (typeof Bun !== 'undefined') { | ||
| return { name: 'bun', version: Bun.version }; | ||
| } | ||
|
|
||
| return { name: 'node', version: process.version }; | ||
| } | ||
|
|
||
| /** | ||
| * Initializes the Sentry Elysia SDK. | ||
| * | ||
| * @example | ||
| * ```javascript | ||
| * import * as Sentry from '@sentry/elysia'; | ||
| * | ||
| * Sentry.init({ | ||
| * dsn: '__DSN__', | ||
| * tracesSampleRate: 1.0, | ||
| * }); | ||
| * ``` | ||
| */ | ||
| export function init(userOptions: ElysiaOptions = {}): NodeClient | undefined { | ||
| applySdkMetadata(userOptions, 'elysia'); | ||
|
|
||
| const options = { | ||
| ...userOptions, | ||
| platform: 'javascript', | ||
| runtime: getRuntime(), | ||
| serverName: userOptions.serverName || global.process.env.SENTRY_NAME || os.hostname(), | ||
| }; | ||
|
|
||
| options.transport = options.transport || makeFetchTransport; | ||
|
|
||
| if (options.defaultIntegrations === undefined) { | ||
| options.defaultIntegrations = getDefaultIntegrations(options); | ||
| } | ||
|
|
||
| return initNode(options); |
There was a problem hiding this comment.
getRuntime() falls back to { name: 'node', version: process.version } when Bun is undefined, but init() still calls init from @sentry/bun. The Bun SDK’s init references Bun.version internally, so calling @sentry/elysia.init() in a non-Bun runtime will still throw at runtime. Either explicitly enforce Bun-only usage (and throw a clear error when Bun is undefined) or conditionally use a Node-compatible init implementation when running on Node.
Member
There was a problem hiding this comment.
Might be relevant no? Not sure how it behaves actually if Elysia is called in a Node environment.
Member
Author
There was a problem hiding this comment.
Good catch, I haven't tried it out, I think I will fix it in the bun SDK and maybe add a node variant test for elysia just in case.
19113b3 to
68051af
Compare
68051af to
88952b2
Compare
On Node.js, the root HTTP span is created by Node's HTTP instrumentation with only the raw URL. The Elysia OTel plugin creates a child span with route info but doesn't propagate it up. This updates the root span and isolation scope with the parameterized route name in onAfterHandle (for successful requests on Node.js) and onError (for all runtimes). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Node 20 does not support running .ts files directly. Node 24 has TypeScript stripping enabled by default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e35f523 to
1d4ea2a
Compare
logaretm
added a commit
to getsentry/platformicons
that referenced
this pull request
Mar 24, 2026
Add SVG icons for the Elysia web framework in both standard (20x20) and large (80x80) sizes, sourced from the official Elysia logo. Ref: getsentry/sentry-javascript#19509 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Mar 24, 2026
Add getting started guide for the new @sentry/elysia package covering Bun and Node.js runtimes, error capturing, automatic tracing, and distributed trace propagation. Wire up the Elysia platform icon. Refs getsentry/sentry-javascript#19509 Co-Authored-By: Claude <noreply@anthropic.com>
8 tasks
46 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Decisions:
@sentry/bunsince Elysia is Bun-first.bunServerIntegrationto avoid competing root spans, as Elysia creates its own.5xxand <=299, skips3xx/4xx. Aligned with Fastify. Overridable viashouldHandleError.spanEnd(still empty at that point) and strip them inbeforeSendEvent. Unless the user provides a named function, we will strip them, check the trace below as an example of a named functionlogRequestvs the stripped event handlers in other life cycle hooks.TODOs:
Closes #18956