ref(feedback): Use `debug` instead of `logger` by AbhiPrasad · Pull Request #17027 · getsentry/sentry-javascript

AbhiPrasad · 2025-07-15T19:51:21Z

resolves #16949

cursor

Bug: Incorrect `debug` Usage Causes Errors

The debug function from @sentry/core was incorrectly used as an object with an error method (e.g., debug.error(...)), replacing previous logger.error(...) calls. As debug is a function, not an object, this causes a TypeScript compilation error and, in debug builds, a runtime TypeError: debug.error is not a function. This issue breaks feedback-related flows in files like Form.tsx and core/integration.ts.

packages/feedback/src/modal/components/Form.tsx#L128-L135

sentry-javascript/packages/feedback/src/modal/components/Form.tsx

Lines 128 to 135 in b8a82ed

    
               }, 
        
               { attachments: data.attachments }, 
        
             ); 
        
             onSubmitSuccess(data, eventId); 
        
           } catch (error) { 
        
             DEBUG_BUILD && debug.error(error); 
        
             setError(error as string); 
        
             onSubmitError(error as Error);

packages/feedback/src/core/integration.ts#L193-L247

sentry-javascript/packages/feedback/src/core/integration.ts

Lines 193 to 247 in b8a82ed

    
               modalIntegration = modalIntegrationFn() as FeedbackModalIntegration; 
        
               addIntegration(modalIntegration); 
        
             } catch { 
        
               DEBUG_BUILD && 
        
                 debug.error( 
        
                   '[Feedback] Error when trying to load feedback integrations. Try using `feedbackSyncIntegration` in your `Sentry.init`.', 
        
                 ); 
        
               throw new Error('[Feedback] Missing feedback modal integration!'); 
        
             } 
        
             try { 
        
               const screenshotIntegrationFn = screenshotRequired 
        
                 ? getScreenshotIntegration 
        
                   ? getScreenshotIntegration() 
        
                   : await lazyLoadIntegration('feedbackScreenshotIntegration', scriptNonce) 
        
                 : undefined; 
        
               if (screenshotIntegrationFn) { 
        
                 screenshotIntegration = screenshotIntegrationFn() as FeedbackScreenshotIntegration; 
        
                 addIntegration(screenshotIntegration); 
        
               } 
        
             } catch { 
        
               DEBUG_BUILD && 
        
                 debug.error('[Feedback] Missing feedback screenshot integration. Proceeding without screenshots.'); 
        
             } 
        
             const dialog = modalIntegration.createDialog({ 
        
               options: { 
        
                 ...options, 
        
                 onFormClose: () => { 
        
                   dialog?.close(); 
        
                   options.onFormClose?.(); 
        
                 }, 
        
                 onFormSubmitted: () => { 
        
                   dialog?.close(); 
        
                   options.onFormSubmitted?.(); 
        
                 }, 
        
               }, 
        
               screenshotIntegration, 
        
               sendFeedback, 
        
               shadow: _createShadow(options), 
        
             }); 
        
             return dialog; 
        
           }; 
        
           const _attachTo = (el: Element | string, optionOverrides: OverrideFeedbackConfiguration = {}): Unsubscribe => { 
        
             const mergedOptions = mergeOptions(_options, optionOverrides); 
        
             const targetEl = 
        
               typeof el === 'string' ? DOCUMENT.querySelector(el) : typeof el.addEventListener === 'function' ? el : null; 
        
             if (!targetEl) { 
        
               DEBUG_BUILD && debug.error('[Feedback] Unable to attach to target element'); 
        
               throw new Error('Unable to attach to target element');

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

ref(feedback): Use debug instead of logger

b8a82ed

AbhiPrasad requested a review from a team July 15, 2025 19:51

AbhiPrasad self-assigned this Jul 15, 2025

AbhiPrasad requested review from s1gr1d and stephanie-anderson and removed request for a team July 15, 2025 19:51

AbhiPrasad requested a review from a team as a code owner July 15, 2025 19:51

billyvg approved these changes Jul 15, 2025

View reviewed changes

cursor bot reviewed Jul 15, 2025

View reviewed changes

AbhiPrasad enabled auto-merge (squash) July 15, 2025 20:31

AbhiPrasad merged commit 465f64d into develop Jul 15, 2025
253 of 255 checks passed

AbhiPrasad deleted the abhi-debug-feedback branch July 15, 2025 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(feedback): Use `debug` instead of `logger`#17027

ref(feedback): Use `debug` instead of `logger`#17027
AbhiPrasad merged 1 commit intodevelopfrom
abhi-debug-feedback

AbhiPrasad commented Jul 15, 2025

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	},
	{ attachments: data.attachments },
	);
	onSubmitSuccess(data, eventId);
	} catch (error) {
	DEBUG_BUILD && debug.error(error);
	setError(error as string);
	onSubmitError(error as Error);

	modalIntegration = modalIntegrationFn() as FeedbackModalIntegration;
	addIntegration(modalIntegration);
	} catch {
	DEBUG_BUILD &&
	debug.error(
	'[Feedback] Error when trying to load feedback integrations. Try using `feedbackSyncIntegration` in your `Sentry.init`.',
	);
	throw new Error('[Feedback] Missing feedback modal integration!');
	}

	try {
	const screenshotIntegrationFn = screenshotRequired
	? getScreenshotIntegration
	? getScreenshotIntegration()
	: await lazyLoadIntegration('feedbackScreenshotIntegration', scriptNonce)
	: undefined;

	if (screenshotIntegrationFn) {
	screenshotIntegration = screenshotIntegrationFn() as FeedbackScreenshotIntegration;
	addIntegration(screenshotIntegration);
	}
	} catch {
	DEBUG_BUILD &&
	debug.error('[Feedback] Missing feedback screenshot integration. Proceeding without screenshots.');
	}

	const dialog = modalIntegration.createDialog({
	options: {
	...options,
	onFormClose: () => {
	dialog?.close();
	options.onFormClose?.();
	},
	onFormSubmitted: () => {
	dialog?.close();
	options.onFormSubmitted?.();
	},
	},
	screenshotIntegration,
	sendFeedback,
	shadow: _createShadow(options),
	});

	return dialog;
	};

	const _attachTo = (el: Element \| string, optionOverrides: OverrideFeedbackConfiguration = {}): Unsubscribe => {
	const mergedOptions = mergeOptions(_options, optionOverrides);

	const targetEl =
	typeof el === 'string' ? DOCUMENT.querySelector(el) : typeof el.addEventListener === 'function' ? el : null;

	if (!targetEl) {
	DEBUG_BUILD && debug.error('[Feedback] Unable to attach to target element');
	throw new Error('Unable to attach to target element');

Uh oh!

Conversation

AbhiPrasad commented Jul 15, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Incorrect `debug` Usage Causes Errors

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants