ref(node): Add sentry.parent_span_already_sent attribute#16870
Merged
ref(node): Add sentry.parent_span_already_sent attribute#16870
sentry.parent_span_already_sent attribute#16870Conversation
sentry.transaction.parent_span_already_sent attributesentry.parent_span_already_sent attribute
Contributor
size-limit report 📦
|
s1gr1d
approved these changes
Jul 10, 2025
Lms24
approved these changes
Jul 11, 2025
Member
Lms24
left a comment
There was a problem hiding this comment.
I'm not 100% happy with the behaviour overall but adding the attribute for diagnosis is a good idea!
msonnb
pushed a commit
that referenced
this pull request
Jul 15, 2025
This adds a new attribute to spans that we send from the Node SDK because their parent span was already sent. This can be used by us or customers to debug why certain things show up as transactions/root spans in product. We could possibly also use this in the trace view to give users helpful pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new attribute to spans that we send from the Node SDK because their parent span was already sent. This can be used by us or customers to debug why certain things show up as transactions/root spans in product. We could possibly also use this in the trace view to give users helpful pointers.