feat: Only emit __esModule properties in CJS modules when there is a default export#15018
Merged
feat: Only emit __esModule properties in CJS modules when there is a default export#15018
__esModule properties in CJS modules when there is a default export#15018Conversation
added 3 commits
January 14, 2025 21:38
33073e5 to
ebc1621
Compare
mydea
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #3105
By having the
__esModuleproperty in files where we don't have default exports we may trick tooling into thinking that there would be a default export. The probability of that happening nowadays is pretty low, but since__esModuleis a non-standard property we should limit it to the minimum.