feat(remix)!: Drop support for Remix v1#14988
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
onurtemizkan
left a comment
There was a problem hiding this comment.
Looks great to me! Added a few minor comments.
packages/remix/test/integration/test/client/errorboundary.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Onur Temizkan <onur@narval.co.uk>
Co-authored-by: Onur Temizkan <onur@narval.co.uk>
| TransactionEvent, | ||
| } from '@sentry/core'; | ||
|
|
||
| export const envelopeUrlRegex = /\.sentry\.io\/api\/\d+\/envelope\//; |
Check failure
Code scanning / CodeQL
Missing regular expression anchor
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to add anchors to the regular expression to ensure it matches the expected part of the URL and not any arbitrary substring. Specifically, we should add the ^ anchor at the beginning to ensure the match starts at the beginning of the string and the $ anchor at the end to ensure the match ends at the end of the string.
- Modify the regular expression on line 16 to include
^at the beginning and$at the end. - This change ensures that the regex will only match strings that exactly match the pattern, preventing unintended matches.
| @@ -15,3 +15,3 @@ | ||
|
|
||
| export const envelopeUrlRegex = /\.sentry\.io\/api\/\d+\/envelope\//; | ||
| export const envelopeUrlRegex = /^\.sentry\.io\/api\/\d+\/envelope\/$/; | ||
|
|
- Updates the label for remix integration tests. - Updates client types for captureRemixServerException params Follow up to #14988 --------- Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
ref ##14263