fix(v8/vue): Re-throw error when no errorHandler exists#14943
Merged
Conversation
Lms24
reviewed
Jan 8, 2025
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jan 9, 2025
Member
Lms24
left a comment
There was a problem hiding this comment.
Realizing we already have tests that need to be adjusted anyway, so feel free to merge once this is done (ofc feel free to add tests if it makes sense). Thanks for tackling this!
Lms24
reviewed
Jan 9, 2025
Member
Lms24
left a comment
There was a problem hiding this comment.
One more Q but feel free to merge once it is addressed :)
70c98ae to
a6459e2
Compare
This was referenced Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for v9: #14958