feat(core)!: Add normalizedRequest to samplingContext#14902
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
reviewed
Jan 3, 2025
| !!samplingContext.normalizedRequest.headers | ||
| ); | ||
| }, | ||
| debug: true, |
Member
There was a problem hiding this comment.
l: we probably don't need this
Suggested change
| debug: true, |
Lms24
approved these changes
Jan 3, 2025
Lms24
reviewed
Jan 3, 2025
docs/migration/v8-to-v9.md
Outdated
| - The `TransactionNamingScheme` type has been removed. There is no replacement. | ||
| - The `Request` type has been removed. Use `RequestEventData` type instead. | ||
| - The `IntegrationClass` type is no longer exported - it was not used anymore. Instead, use `Integration` or `IntegrationFn`. | ||
| - - The `samplingContext.request` attribute in the `tracesSampler` has been removed. Use `samplingContext.normalizedRequest` instead. |
Member
There was a problem hiding this comment.
l: Maybe we call out the type change a bit more?
Suggested change
| - - The `samplingContext.request` attribute in the `tracesSampler` has been removed. Use `samplingContext.normalizedRequest` instead. | |
| - The `samplingContext.request` attribute in the `tracesSampler` has been removed. Use `samplingContext.normalizedRequest` instead. Note that the type of `normalizedRequest` differs from `request`. |
normalizedRequest to samplingContextnormalizedRequest to samplingContext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sampling context didn't include the
requestobject anymore. By adding thenormalizedRequest, this data is added again.