feat(react): React Router v7 support (library)#14513
Merged
Conversation
Member
Author
|
@lforst this pr contains some deprecations for react router v6 exports, should we include this in the v9 roadmap? |
onurtemizkan
approved these changes
Nov 28, 2024
Contributor
onurtemizkan
left a comment
There was a problem hiding this comment.
Looks good to me! Only need to double check if we need to update the vendored types for RR v7, they're pretty much loosened anyways, but still worth checking IMO.
dev-packages/e2e-tests/test-applications/react-router-7-spa/package.json
Outdated
Show resolved
Hide resolved
lforst
approved these changes
Nov 28, 2024
2 tasks
|
hey @chargome - are there any additional changes required on Sentry's part to support the framework flow? I'm interested in knowing more details about this as I've just migrated from Remix to RR7 so naturally I'm using it as a framework. |
Member
Author
3 tasks
AbhiPrasad
added a commit
that referenced
this pull request
Dec 17, 2024
Removes code deprecated in #14513 and adds changelog entry as appropriate: Removed methods: 1. The `wrapUseRoutes` method has been removed. Use `wrapUseRoutesV6` or `wrapUseRoutesV7` instead depending on what version of react router you are using. 2. The `wrapCreateBrowserRouter` method has been removed. Use `wrapCreateBrowserRouterV6` or `wrapCreateBrowserRouterV7` depending on what version of react router you are using.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR basically handles the library part of rr7, not the framework part.
Since v7 is v6 compatible we just adapt and re-export existing functions from v6.
reactrouterv6-compat-utils.tsxfilecloses #14518