feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
Merged
AbhiPrasad merged 2 commits intodevelopfrom Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699AbhiPrasad merged 2 commits intodevelopfrom
spanTimeInputToSeconds for otel span exporter#12699AbhiPrasad merged 2 commits intodevelopfrom
Conversation
AbhiPrasad
reviewed
Jun 28, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Can we add a test for this? Seems really weird that this has this behaviour.
Contributor
Author
|
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds. |
Member
|
Can we instead just export |
Contributor
Author
Oh I wasn't aware of that! Updating the PR. |
d73b071 to
ae4a0f2
Compare
Contributor
size-limit report 📦
|
ae4a0f2 to
9da19ec
Compare
spanTimeInputToSeconds for otel span exporter
mydea
approved these changes
Jul 1, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
AbhiPrasad
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)