feat(solid): Remove need to pass router hooks to solid integration#12617
Merged
andreiborza merged 5 commits intodevelopfrom Jun 25, 2024
Merged
feat(solid): Remove need to pass router hooks to solid integration#12617andreiborza merged 5 commits intodevelopfrom
andreiborza merged 5 commits intodevelopfrom
Conversation
1dd6a6d to
f2e8773
Compare
Contributor
size-limit report 📦
|
mydea
reviewed
Jun 24, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
mydea
reviewed
Jun 25, 2024
packages/solid/package.json
Outdated
| "import": { | ||
| "types": "./build/types/index.d.ts", | ||
| "default": "./build/esm/index.js" | ||
| "default": "./build/esm/index.js", |
Member
There was a problem hiding this comment.
This has to be the other way around, see #12404 - is there a reason you reordered this? types should always come first!
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sentry/solidPreviously, we had to pass
useBeforeLeaveanduseLocationtosolidRouterBrowserTracingIntegration. This has now been removed in favor of importing the router hooks directly within the sdk as needed.Import
solidRouterBrowserTracingIntegrationfrom@sentry/solid/solidrouterand add it toSentry.init:As a result, the SDK has an optional peer dependency on
@solidjs/routerv0.13.4+when usingsolidRouterBrowserTracingIntegration.Note to maintainers
This package outputs types at the
buildroot instead ofbuild/typesto better support projects that don't usemoduleResolution: "bundler".