Skip to content

fix(feedback): Send feedback rejects invalid responses #12518

Merged
c298lee merged 5 commits intodevelopfrom
cl/send-feedback-error
Jun 18, 2024
Merged

fix(feedback): Send feedback rejects invalid responses #12518
c298lee merged 5 commits intodevelopfrom
cl/send-feedback-error

Conversation

@c298lee
Copy link
Copy Markdown
Contributor

@c298lee c298lee commented Jun 17, 2024 •
edited
Loading

sendFeedback rejects if the response isn't a valid status code. Also propagates message into form.
image

Fixes #12476

@c298lee c298lee requested a review from ryan953 June 17, 2024 19:57
@c298lee c298lee requested a review from a team as a code owner June 17, 2024 19:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.03 KB (0%)
@sentry/browser (incl. Tracing) 33.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.94 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.27 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.01 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.19 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.02 KB (-0.04% 🔽)
@sentry/browser (incl. metrics) 26.21 KB (0%)
@sentry/browser (incl. Feedback) 38.24 KB (-0.07% 🔽)
@sentry/browser (incl. sendFeedback) 26.65 KB (+0.03% 🔺)
@sentry/browser (incl. FeedbackAsync) 31.22 KB (+0.03% 🔺)
@sentry/react 24.8 KB (0%)
@sentry/react (incl. Tracing) 36.28 KB (0%)
@sentry/vue 26.03 KB (0%)
@sentry/vue (incl. Tracing) 35.06 KB (0%)
@sentry/svelte 22.17 KB (0%)
CDN Bundle 23.36 KB (0%)
CDN Bundle (incl. Tracing) 34.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.99 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.19 KB (-0.01% 🔽)
CDN Bundle - uncompressed 68.68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.29 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 213.74 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.33 KB (+0.02% 🔺)
@sentry/nextjs (client) 35.61 KB (0%)
@sentry/sveltekit (client) 33.83 KB (0%)
@sentry/node 112.67 KB (0%)
@sentry/node - without tracing 90.07 KB (0%)
@sentry/aws-serverless 99.16 KB (0%)

@c298lee c298lee changed the title Cl/send feedback error fix(feedback): Send feedback rejects invalid responses Jun 17, 2024
ryan953
ryan953 reviewed Jun 17, 2024
View reviewed changes
ryan953
ryan953 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to unblock

billyvg
billyvg approved these changes Jun 18, 2024
View reviewed changes
@c298lee c298lee merged commit e0302c3 into develop Jun 18, 2024
@c298lee c298lee deleted the cl/send-feedback-error branch June 18, 2024 16:55
@gokulk16 gokulk16 mentioned this pull request Jul 11, 2024
Merged
@FengShangWuQi FengShangWuQi mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

@ryan953 ryan953 ryan953 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User Feedback submission failure is reflected as successful through the UI

3 participants

@c298lee @billyvg @ryan953