feat(solidjs): Add sourcemap instructions to README#12425
feat(solidjs): Add sourcemap instructions to README#12425andreiborza merged 2 commits intodevelopfrom
Conversation
Lms24
left a comment
There was a problem hiding this comment.
I'd recommend we use the debugId-based source maps upload instructions: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/
We should probably update this in the Svelte instructions as well but let's start here.
With "using the wizard", you mean adding a path to the -i sourcemaps wizard? Or setting up the entire SDK, including sourcemaps, with the wizard?
with using the wizard I meant |
|
Another question: Have you tried using the Vite plugin? Is there a reason we should recommend the CLI over the plugin? |
yes, I tried both the vite plugin and the CLI. I'm also leaning towards just recommending the vite plugin because it's so much simpler. |
|
@Lms24 I removed the section on CLI and just link to the source map guide in the docs. lmk if you think we should add more. |
e2791fa to
2fc0eea
Compare
Lms24
left a comment
There was a problem hiding this comment.
Thanks, I think thats a good idea. Less duplication.
I pretty much copied these instructions from the svelte sdk. They work, although the wizard does not detect the sdk yet.
That being said, I was thinking of recommending using the wizard over creating a bash script, wdyat?
It works:
