test(e2e): Add ESM http instrumentation test#12379
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
Jun 6, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
some small comments, but overall looks nice!
dev-packages/e2e-tests/test-applications/node-express-esm-preload/src/app.mjs
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-express-esm-preload/src/app.mjs
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-express-esm-preload/src/app.mjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
mydea
approved these changes
Jun 7, 2024
Member
Author
|
oof sorry for the stupid leftovers, I just extracted this out from the layer mess and should have given it a better check before PRing |
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
add a test to our ESM Express e2e test app to test that http instrumentation is working correctly by ensuring a `http.client` span is captured. --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick by-product of working on the ESM lambda layer: This PR adds a test to our ESM Express e2e test app to test that http instrumentation is working correctly by ensuring a
http.clientspan is captured.