fix: Let Edge to send fetch requests using default config#1236
Merged
kamilogorek merged 1 commit intomasterfrom Feb 21, 2018
Merged
fix: Let Edge to send fetch requests using default config#1236kamilogorek merged 1 commit intomasterfrom
kamilogorek merged 1 commit intomasterfrom
Conversation
33dc820 to
465f492
Compare
HazAT
approved these changes
Feb 21, 2018
Member
HazAT
left a comment
There was a problem hiding this comment.
I guess this is fine and probably the only thing we could do here.
Even though I am not sure if we still require referrer on the server but we can't force people to update their server so we have to live with it.
This was referenced Mar 15, 2018
chargome
added a commit
that referenced
this pull request
Mar 23, 2026
Fixes Dependabot alerts #1236 (SSE Event Injection) and #1237 (Path Traversal via Double Decoding) by updating the yarn.lock resolution for h3 from 1.15.5 to 1.15.10. Easier fix than #19910 as Nuxt 3.21.x introduced breaking type changes (removed nitro from NuxtOptions and nitro:config from NuxtHooks). Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com>
logaretm
pushed a commit
that referenced
this pull request
Mar 24, 2026
Fixes Dependabot alerts #1236 (SSE Event Injection) and #1237 (Path Traversal via Double Decoding) by updating the yarn.lock resolution for h3 from 1.15.5 to 1.15.10. Easier fix than #19910 as Nuxt 3.21.x introduced breaking type changes (removed nitro from NuxtOptions and nitro:config from NuxtHooks). Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1233
We add
referrerbecause this comment #1177 (comment)However, there's no easy way to test this behavior, as:
fetchwon't call it's native implementation, therefore not throw an errorfetchwon't modify response object, and without it, we'll always jump intoonErrorhandler because we get nookin resp dataI'm not really convinced if this is a good idea... It just feels odd, but I cannot think of any simple, yet an acceptable solution to this issue.
Thoughts?