fix(nextjs): correct types conditional export ordering#12355
Merged
mydea merged 1 commit intogetsentry:developfrom Jun 7, 2024
Merged
fix(nextjs): correct types conditional export ordering#12355mydea merged 1 commit intogetsentry:developfrom
mydea merged 1 commit intogetsentry:developfrom
Conversation
As stated in the typescript docs, `types` exports should always come first, so that they are resolved correctly. This also applies to the nested `types` within and `exports` condition.
AbhiPrasad
reviewed
Jun 4, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Damn TIL. We need to fix this for all of our packages then.
mydea
approved these changes
Jun 7, 2024
Member
mydea
left a comment
There was a problem hiding this comment.
Thanks a lot, I'll open a follow up PR also updating this in other places 🙏
mydea
added a commit
that referenced
this pull request
Jun 7, 2024
Ensure the `types` export is always first, as documented here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing Follow up to #12355
mydea
added a commit
that referenced
this pull request
Jun 7, 2024
Ensure the `types` export is always first, as documented here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing Follow up to #12355
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
## Description As stated [here](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing) in the typescript docs, `types` exports should always come first, so that they are resolved correctly. This also applies to the nested `types` within and `exports` condition. This corrects an issue where `eslint-import-resolver-typescript` was not correctly resolving the full types for Sentry.
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
Ensure the `types` export is always first, as documented here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing Follow up to #12355
This was referenced Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As stated here in the typescript docs,
typesexports should always come first, so that they are resolved correctly. This also applies to the nestedtypeswithin andexportscondition.This corrects an issue where
eslint-import-resolver-typescriptwas not correctly resolving the full types for Sentry.