Conversation
| function RavenProvider() { | ||
| this.$get = [ | ||
| '$window', | ||
| function($window) { |
There was a problem hiding this comment.
no idea how this passed linter before... is your eslint mis-configured?
There was a problem hiding this comment.
We didn't have no-unused-vars rule till this PR
Gruntfile.js
Outdated
| function AddPluginBrowserifyTransformer() { | ||
| return function(file) { | ||
| return through(function(buf, enc, next) { | ||
| return through(function(buf, _enc, next) { |
There was a problem hiding this comment.
this function is wrong. It should be using _enc and it seems to want to add the require at the end of every chunk
There was a problem hiding this comment.
| "no-shadow": 2, | ||
| "no-undef": 2, | ||
| "no-unused-vars": [2, {"args": "none"}], | ||
| "no-unused-vars": [2, {"args": "all", "argsIgnorePattern": "^_"}], |
There was a problem hiding this comment.
Can you please change this to "args": "after-used" instead?
| var angularPattern = /^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.*?)\n?(\S+)$/; | ||
| var moduleName = 'ngRaven'; | ||
|
|
||
| function ExceptionHandlerProvider($provide) { |
There was a problem hiding this comment.
Could you separate this code from a PR into a new one? It's changing the internal code for the plugin (constant vs. provider), therefore it should be taken care of on its own.
|
We'll change most of the linting rules in v4, so I'll close this one due to inactivity, sorry |
…est apps Fixes Dependabot alerts #1227 and #1228. Patches CVE-2026-27980 (unbounded next/image disk cache growth). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…est apps (#19917) Fixes Dependabot alerts #1227 and #1228. Patches CVE-2026-27980 (unbounded next/image disk cache growth). Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Before submitting a pull request, please verify the following: