test(e2e): Update node version used for e2e tests#12031
Merged
Conversation
Member
Author
|
I did some more digging: For whatever reason, when I bump node from 18.18.2 to 18.19.0, some of the test apps start to fail with this: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/francesco/git/sentry-javascript/dev-packages/e2e-tests/test-applications/vue-3/start-event-proxy.ts
at new NodeError (node:internal/errors:405:5)
at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:136:11)
at defaultGetFormat (node:internal/modules/esm/get_format:182:36)
at defaultLoad (node:internal/modules/esm/load:101:20)
at nextLoad (node:internal/modules/esm/hooks:864:28)
at load (/Users/francesco/git/sentry-javascript/dev-packages/e2e-tests/test-applications/vue-3/node_modules/.pnpm/ts-node@10.9.1_@types+node@20.12.12_typescript@5.3.3/node_modules/ts-node/dist/child/child-loader.js:19:122)
at nextLoad (node:internal/modules/esm/hooks:864:28)
at Hooks.load (node:internal/modules/esm/hooks:447:26)
at MessagePort.handleMessage (node:internal/modules/esm/worker:196:24)
at [nodejs.internal.kHybridDispatch] (node:internal/event_target:786:20) {
code: 'ERR_UNKNOWN_FILE_EXTENSION'
}😬 |
Contributor
size-limit report 📦
|
Lms24
approved these changes
May 15, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Lol, I also just used CJS in sveltekit2+svelte5 app because ts-node didn't play nicely with the app's tsconfig and couldn't solve it quickly. Totally fine to do this generally from my PoV 👍
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
Extracted this out from #12020 For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a `.mjs` file directly - works just as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted this out from #12020
For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a
.mjsfile directly - works just as well!