test(node): Add test for express without tracing#12014
Merged
Conversation
s1gr1d
approved these changes
May 14, 2024
dev-packages/node-integration-tests/suites/express/without-tracing/test.ts
Show resolved
Hide resolved
dev-packages/node-integration-tests/suites/express/without-tracing/test.ts
Show resolved
Hide resolved
Lms24
approved these changes
May 14, 2024
05273da to
bfffe68
Compare
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
Just to ensure we do not regress here. Request isolation should work even without tracing (which means, even without the express integration added - that is only added when tracing is enabled, today!). Really, the only thing missing should be `transactionName`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to ensure we do not regress here.
Request isolation should work even without tracing (which means, even without the express integration added - that is only added when tracing is enabled, today!).
Really, the only thing missing should be
transactionName.