ref(feedback): Simplify feedback function params#11957
Merged
Conversation
…ass options around more often
ryan953
commented
May 8, 2024
Comment on lines
-59
to
-61
| --dialog-inset: auto var(--page-margin) var(--page-margin) auto; | ||
| --dialog-padding: 24px; | ||
|
|
Member
Author
There was a problem hiding this comment.
these and a bunch of stuff above are in Dialog.css.ts now, along with all the :host { ... } stuff to wrap it.
Contributor
size-limit report 📦
|
billyvg
approved these changes
May 8, 2024
| options: FeedbackInternalOptions; | ||
| } | ||
|
|
||
| export function DialogHeader({ formTitle, showBranding }: Props): VNode { |
Member
There was a problem hiding this comment.
l: i kind of like having the specific props, esp for this component where it only needs 2 of the options
c298lee
approved these changes
May 8, 2024
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
We can simplify the function params and only pass options around most of the time. I also moved some dialog specific css variables into dialog.css.ts so they can be async loaded, which depends on the options config. Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can simplify the function params and only pass options around most of the time.
I also moved some dialog specific css variables into dialog.css.ts so they can be async loaded, which depends on the options config.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).