Merged
Conversation
For now, to unblock the release - we need to fix this, but today we cannot run them because we try to fetch the modal/screenshot integrations from the CDN for the version that is not yet deployed to the CDN.
lforst
approved these changes
May 3, 2024
mydea
added a commit
that referenced
this pull request
May 6, 2024
This reverts #11888, and ensures the feedback tests actually work on CDN. For this, we now ensure to serve this locally, so this will work also on release branches. It means you have to use `getLocalTestUrl` instead of `getLocalTestPath` to work. (side note: We can/should probably just remove `getLocalTestPath` overall 🤔 URL based is much more realistic and IMHO better. I'll do that in a follow up, maybe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, to unblock the release - we need to fix this, but today we cannot run them because we try to fetch the modal/screenshot integrations from the CDN for the version that is not yet deployed to the CDN.
In a follow up I'll try to make these tests actually work.