feat(browser): Disable standalone http.client spans#11879
Merged
Conversation
Lms24
approved these changes
May 3, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
What a mess :(
(not your PR for the record 😅 )
Contributor
size-limit report 📦
|
Since there seem to be issues around this in the backend/UI today, we decided to not send these for now. We may revisit this later...
1953981 to
ba33408
Compare
Lms24
added a commit
that referenced
this pull request
May 10, 2024
…rent span (#11974) We introduced sending standalone `http.client` spans in #11783. Subsequently, we had to revert this change due to internal timeline problems (😢). However, in the revert PR (#11879) we missed that originally, we checked for an active parent span and only then created an `http.client` span. The result were `http.client` _transactions_ which we also don't want. This patch fixes that by re-introducing the `hasParent` check as it was pre-#11783.
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
…rent span (#11974) We introduced sending standalone `http.client` spans in #11783. Subsequently, we had to revert this change due to internal timeline problems (😢). However, in the revert PR (#11879) we missed that originally, we checked for an active parent span and only then created an `http.client` span. The result were `http.client` _transactions_ which we also don't want. This patch fixes that by re-introducing the `hasParent` check as it was pre-#11783.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there seem to be issues around this in the backend/UI today, we decided to not send these for now. We may revisit this later...
I left the code to send this in for now, so we can revert this more easily if needed.