Skip to content

fix(serverless): Check if cloud event callback is a function (#9044)#11701

Merged
AbhiPrasad merged 3 commits intogetsentry:developfrom
tcoyze:fix/gcpfunction-cloud-events-callback
Apr 22, 2024
Merged

fix(serverless): Check if cloud event callback is a function (#9044)#11701
AbhiPrasad merged 3 commits intogetsentry:developfrom
tcoyze:fix/gcpfunction-cloud-events-callback

Conversation

@tcoyze
Copy link
Copy Markdown
Contributor

@tcoyze tcoyze commented Apr 19, 2024 •
edited
Loading

Closes #9044

Adds relevant tests for testing handlers that return promises.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch from 6e4e95d to f2d903b Compare April 19, 2024 18:38
AbhiPrasad
AbhiPrasad reviewed Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a PR! Could you add a test to https://github.com/getsentry/sentry-javascript/blob/f2d903b1e034bd2c388fb0d8d63ce7fce8ef9ef9/packages/google-cloud-serverless/test/gcpfunction/cloud_event.test.ts about this?

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch from f2d903b to b176eb6 Compare April 22, 2024 15:22
@tcoyze
Copy link
Copy Markdown
Contributor Author

tcoyze commented Apr 22, 2024

Thank you for a PR! Could you add a test to https://github.com/getsentry/sentry-javascript/blob/f2d903b1e034bd2c388fb0d8d63ce7fce8ef9ef9/packages/google-cloud-serverless/test/gcpfunction/cloud_event.test.ts about this?

@AbhiPrasad Tests added! Thanks for the review 🙌

AbhiPrasad
AbhiPrasad approved these changes Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution!

@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Apr 22, 2024

ah seems like theres some formatting issues. https://github.com/getsentry/sentry-javascript/actions/runs/8787015686/job/24111825459?pr=11701

Running yarn fix in the package root should handle that!

@tcoyze
Copy link
Copy Markdown
Contributor Author

tcoyze commented Apr 22, 2024

FWIW I have been having build issues, apologies for the failed checks. Resolving those now!

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch 2 times, most recently from e18db31 to 9728041 Compare April 22, 2024 16:33
@tcoyze
Copy link
Copy Markdown
Contributor Author

tcoyze commented Apr 22, 2024

@AbhiPrasad Thanks! Fixed that, and rebased 😄

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch from 9728041 to f3d3c16 Compare April 22, 2024 16:36
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 22, 2024
Closed
@AbhiPrasad AbhiPrasad merged commit 6a8a410 into getsentry:develop Apr 22, 2024
@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Apr 22, 2024

develop reflects our current work on 8.0.0, the next major version. I'll take care of backporting this change to the 7.0.0 set of SDKs - #11729

Thanks!

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 22, 2024
Merged
mydea pushed a commit that referenced this pull request Apr 23, 2024
@AbhiPrasad
fix(serverless): [v7] Check if cloud event callback is a function (#1…
8da1c8d 
…1734)

Backport of #11701 to
v7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: callback is not a function thrown by Sentry.GCPFunction.wrapCloudEventFunction

2 participants

@tcoyze @AbhiPrasad