fix(node): Allow use of NodeClient without calling init#11585
Merged
AbhiPrasad merged 2 commits intodevelopfrom Apr 16, 2024
Merged
fix(node): Allow use of NodeClient without calling init#11585AbhiPrasad merged 2 commits intodevelopfrom
NodeClient without calling init#11585AbhiPrasad merged 2 commits intodevelopfrom
Conversation
NodeClient without calling initNodeClient without calling init
mydea
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs exporting so that the
NodeClientcan be used without calling the Nodeinit.There is a lot called in the Node init that is a hard requirement for the
NodeClientto function. Should these not be called in the constructor?