Merged
Conversation
AbhiPrasad
approved these changes
Apr 11, 2024
Contributor
size-limit report 📦
|
fbc9bb0 to
5d905d6
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Remove the last public export of the `Hub` class. Now that it's gone there are no more breaking changes (🤞). The class still remains in the package because it's still used internally for now but we can remove it (and shave off some well needed bytes) throught the v8 beta cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the last public export of the
Hubclass. Now that it's gone there are no more breaking changes (🤞). The class still remains in the package because it's still used internally for now but we can remove it (and shave off some well needed bytes) throught the v8 beta cycle.actually thought this would be more work than just removing the export lol
ref #11482