feat(replay): Merge packages together & ensure bundles are built#11552
Merged
feat(replay): Merge packages together & ensure bundles are built#11552
Conversation
Contributor
size-limit report 📦
|
714312e to
b49969f
Compare
somehow the text based is not working...
Member
|
can we add entries in size-limit for only modal and only screenshot? just want to make sure their individual builds are ok too |
billyvg
reviewed
Apr 11, 2024
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| replaysOnErrorSampleRate: 1.0, | ||
| replaysSessionSampleRate: 0, | ||
| replaysSessionSampleRate: 1.0, |
Member
There was a problem hiding this comment.
I think this was intentional to make sure that replay is captured when in buffering mode
Member
Author
There was a problem hiding this comment.
it is not actually doing this today, I believe? At least the test failed 🤔 I merged this in now so we are unblocked, we can revert/tweak this a bit in a follow up!
b49969f to
4bc8457
Compare
c298lee
reviewed
Apr 11, 2024
| ...makeBundleConfigVariants( | ||
| makeBaseBundleConfig({ | ||
| bundleType: 'addon', | ||
| entrypoints: ['src/modal/integration.tsx'], |
Contributor
There was a problem hiding this comment.
Suggested change
| entrypoints: ['src/modal/integration.tsx'], | |
| entrypoints: ['src/modal/integration.ts'], |
Contributor
There was a problem hiding this comment.
oh I didn't know that! that's interesting
c298lee
approved these changes
Apr 11, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…sentry#11552) This reverts getsentry#11342 and instead generates multiple bundles etc. from the one `@sentry-internal/feedback` package. * The `feedback` CDN bundle integration includes the modal integration for now. * There is also a dedicated modal & screenshot integration on the CDN * Also kept the shims etc. that Ryan added in the now-reverted PR * Size limits now seem correct to me! I bumped them (as they now correctly include the feedback modal etc), but you can see the diff to the screenshots being included (it's not too high, really).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #11342 and instead generates multiple bundles etc. from the one
@sentry-internal/feedbackpackage.feedbackCDN bundle integration includes the modal integration for now.