feat(core): Extract errors from props in unkown inputs#11526
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Apr 11, 2024
e6af5d6 to
ccd37bf
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This changes the handling of unknown inputs for e.g.
`captureException()`, to check if there is a property that holds an
`Error` and use this.
So e.g. this:
```js
const error = new Error('Some error');
Sentry.captureException({ message: 'something happened!', err: error });
```
Will use `Some error` as the error message, and also take the stacktrace
from the error instead of the syntethic one.
There is of course the chance that this leads to false positives, if
something is captured and contains a reference to an unrelated error
instance. But I'd say this is not so likely, and we still keep the
serialised object as `extra` on the event.
Should fix e.g.
https://peated.sentry.io/issues/5166150355/?project=4505138086019073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the handling of unknown inputs for e.g.
captureException(), to check if there is a property that holds anErrorand use this.So e.g. this:
Will use
Some erroras the error message, and also take the stacktrace from the error instead of the syntethic one.There is of course the chance that this leads to false positives, if something is captured and contains a reference to an unrelated error instance. But I'd say this is not so likely, and we still keep the serialised object as
extraon the event.Should fix e.g. https://peated.sentry.io/issues/5166150355/?project=4505138086019073